diff --git a/encoder/encoder.c b/encoder/encoder.c index 9dfe397..3449873 100644 --- a/encoder/encoder.c +++ b/encoder/encoder.c @@ -774,7 +774,7 @@ x264_t *x264_encoder_open( x264_param_t *param ) x264_reduce_fraction( &h->param.i_fps_num, &h->param.i_fps_den ); /* Init x264_t */ - h->i_frame = 0; + h->i_frame = -1; h->i_frame_num = 0; h->i_idr_pic_id = 0; @@ -1238,9 +1238,6 @@ static void x264_fdec_filter_row( x264_t *h, int mb_y ) static inline int x264_reference_update( x264_t *h ) { - if( h->fdec->i_frame >= 0 ) - h->i_frame++; - if( !h->fdec->b_kept_as_ref ) { if( h->param.i_threads > 1 ) @@ -1712,6 +1709,7 @@ int x264_encoder_encode( x264_t *h, x264_pthread_cond_broadcast( &h->lookahead->ifbuf.cv_fill ); } + h->i_frame++; /* 3: The picture is analyzed in the lookahead */ if( !h->frames.current[0] ) x264_lookahead_get_frames( h ); @@ -2080,6 +2078,17 @@ void x264_encoder_close ( x264_t *h ) } } + if( h->param.i_threads > 1) + { + x264_t *thread_prev; + + thread_prev = h->thread[ h->i_thread_phase % h->param.i_threads ]; + x264_thread_sync_ratecontrol( h, thread_prev, h ); + x264_thread_sync_ratecontrol( thread_prev, thread_prev, h ); + h->i_frame = thread_prev->i_frame + 1 - h->param.i_threads; + } + h->i_frame++; + /* Slices used and PSNR */ for( i=0; i<5; i++ ) { diff --git a/encoder/ratecontrol.c b/encoder/ratecontrol.c index b082cc7..ae26d38 100644 --- a/encoder/ratecontrol.c +++ b/encoder/ratecontrol.c @@ -546,17 +546,18 @@ int x264_ratecontrol_new( x264_t *h ) x264_log( h, X264_LOG_WARNING, "2nd pass has fewer frames than 1st pass (%d vs %d)\n", h->param.i_frame_total, rc->num_entries ); } - if( h->param.i_frame_total > rc->num_entries ) + if( h->param.i_frame_total > rc->num_entries + 2*X264_LOOKAHEAD_MAX ) { x264_log( h, X264_LOG_ERROR, "2nd pass has more frames than 1st pass (%d vs %d)\n", h->param.i_frame_total, rc->num_entries ); return -1; } - CHECKED_MALLOCZERO( rc->entry, rc->num_entries * sizeof(ratecontrol_entry_t) ); + /* FIXME: ugly padding because VfW can drop delayed frames */ + CHECKED_MALLOCZERO( rc->entry, (rc->num_entries + 2*X264_LOOKAHEAD_MAX) * sizeof(ratecontrol_entry_t) ); /* init all to skipped p frames */ - for(i=0; inum_entries; i++) + for(i=0; inum_entries + 2*X264_LOOKAHEAD_MAX; i++) { ratecontrol_entry_t *rce = &rc->entry[i]; rce->pict_type = SLICE_TYPE_P; @@ -584,7 +585,7 @@ int x264_ratecontrol_new( x264_t *h ) } e = sscanf(p, " in:%d ", &frame_number); - if(frame_number < 0 || frame_number >= rc->num_entries) + if(frame_number < 0 || frame_number >= rc->num_entries + 2*X264_LOOKAHEAD_MAX) { x264_log(h, X264_LOG_ERROR, "bad frame number (%d) at stats line %d\n", frame_number, i); return -1; @@ -905,7 +906,7 @@ void x264_ratecontrol_start( x264_t *h, int i_force_qp, int overhead ) if( h->param.rc.b_stat_read ) { int frame = h->fenc->i_frame; - assert( frame >= 0 && frame < rc->num_entries ); + assert( frame >= 0 && frame < rc->num_entries + 2*X264_LOOKAHEAD_MAX ); rce = h->rc->rce = &h->rc->entry[frame]; if( h->sh.i_type == SLICE_TYPE_B @@ -1118,7 +1119,7 @@ int x264_ratecontrol_slice_type( x264_t *h, int frame_num ) x264_ratecontrol_t *rc = h->rc; if( h->param.rc.b_stat_read ) { - if( frame_num >= rc->num_entries ) + if( frame_num >= rc->num_entries + 2*X264_LOOKAHEAD_MAX ) { /* We could try to initialize everything required for ABR and * adaptive B-frames, but that would be complicated.